ci(release): Switch from action-prepare-release to Craft #2828
Conversation
This PR migrates from the deprecated action-prepare-release to the new Craft GitHub Actions (reusable workflow or composite action). Changes: - Migrate .github/workflows/prepare_batch_release.yml to Craft reusable workflow
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨
Bug Fixes 🐛
Build / dependencies / internal 🔧
Other
🤖 This preview updates automatically when you update the PR. |
The previous migration incorrectly removed the GitHub App token authentication step. This commit restores it by switching to the composite action pattern which preserves the auth flow.
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
| token: ${{ steps.token.outputs.token }} | ||
| fetch-depth: 0 | ||
| - name: Prepare release | ||
| uses: getsentry/craft@v2 |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| private-key: ${{ secrets.SENTRY_RELEASE_BOT_PRIVATE_KEY }} | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4 |
There was a problem hiding this comment.
Inconsistent checkout version comments across workflow files
Medium Severity
The same actions/checkout commit hash 34e114876b0b11c390a56381ad16ebd13914f8d5 is used across all workflow files, but the version comments are inconsistent: prepare_batch_release.yml says # v4 while all other files say # v2. A single commit hash cannot represent two different versions. If this hash is actually from v2, this represents an unintended downgrade from v4 to v2 across most workflows, potentially causing compatibility issues. The version comment in one of these locations is incorrect.
Additional Locations (2)
| description: Version to release | ||
| required: true | ||
| description: Version to release (or "auto") | ||
| required: false |
There was a problem hiding this comment.
Missing default value for optional version input
Medium Severity
The version input changed from required: true to required: false with a description saying "(or 'auto')", implying auto-detection when left empty. However, no default value is set. When users leave the field empty expecting auto-detection, an empty string is passed to the Craft action at line 38, which may cause the release workflow to fail or behave unexpectedly since Craft likely expects either a valid semver or the literal string "auto".
Summary
This PR migrates from the deprecated
action-prepare-releaseto the new Craft GitHub Actions.Changes
.github/workflows/prepare_batch_release.ymlto Craft reusable workflowDocumentation
See https://getsentry.github.io/craft/github-actions/ for more information.